Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ implement Search for Azure DevOps #4428

Merged
merged 4 commits into from
Dec 3, 2024
Merged

✨ implement Search for Azure DevOps #4428

merged 4 commits into from
Dec 3, 2024

Conversation

JamieMagee
Copy link
Contributor

What kind of change does this PR introduce?

(Is it a bug fix, feature, docs update, something else?)

What is the current behavior?

Search throws an unsupported error

What is the new behavior (if this is a feature change)?**

Search has an implementation for Azure DevOps

  • Tests for the changes have been added (for bug fixes/features)

Which issue(s) this PR fixes

Next step of #4177

Special notes for your reviewer

This does not appear to be used in a current check. However, I verified the functionality by writing an E2E test. Unfortunately, I can't check in the E2E test as we don't have an E2E repository configured for Scorecard.

Does this PR introduce a user-facing change?

For user-facing changes, please add a concise, human-readable release note to
the release-note

(In particular, describe what changes users might need to make in their
application as a result of this pull request.)

implement `Search` for Azure DevOps

@JamieMagee JamieMagee requested a review from a team as a code owner December 3, 2024 05:37
@JamieMagee JamieMagee requested review from spencerschrock and raghavkaul and removed request for a team December 3, 2024 05:37
@JamieMagee JamieMagee marked this pull request as draft December 3, 2024 05:41
@JamieMagee JamieMagee marked this pull request as ready for review December 3, 2024 16:42
@spencerschrock
Copy link
Member

However, I verified the functionality by writing an E2E test. Unfortunately, I can't check in the E2E test as we don't have an E2E repository configured for Scorecard

Do you think it's worth to add the test with a TODO skip?

Similar to

scorecard/e2e/code_review_test.go

Lines 155 to 156 in a7dac35

It("Should return use of code reviews at HEAD - GitLab", func() {
Skip("https://github.com/ossf/scorecard/issues/3193")

@JamieMagee
Copy link
Contributor Author

Do you think it's worth to add the test with a TODO skip?

I didn't realise that was an option. Yeah, I'll add it shortly.

I'll hopefully have some news to share on the E2E Azure DevOps front by the next APAC call.

spencerschrock
spencerschrock reviewed Dec 3, 2024
View reviewed changes
Copy link
Member

@spencerschrock spencerschrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll take a look at the e2e test when added, but otherwise LGTM

@codecov Codecov
Copy link

codecov bot commented Dec 3, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 71.42857% with 18 lines in your changes missing coverage. Please review.

Project coverage is 68.59%. Comparing base (353ed60) to head (fdfe838).
Report is 69 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #4428      +/-   ##
==========================================
+ Coverage   66.80%   68.59%   +1.78%     
==========================================
  Files         230      239       +9     
  Lines       16602    17830    +1228     
==========================================
+ Hits        11091    12230    +1139     
+ Misses       4808     4801       -7     
- Partials      703      799      +96

@JamieMagee
Copy link
Contributor Author

I'll take a look at the e2e test when added, but otherwise LGTM

I've added an E2E test, but I'm not 100% sure if I've hooked it up correctly with the existing E2E test infrastructure.

@JamieMagee
PR comments
67e0ef1 
Signed-off-by: Jamie Magee <[email protected]>
spencerschrock
spencerschrock approved these changes Dec 3, 2024
View reviewed changes
@JamieMagee
PR comments
fdfe838 
Signed-off-by: Jamie Magee <[email protected]>
@spencerschrock spencerschrock enabled auto-merge (squash) December 3, 2024 21:53
@spencerschrock spencerschrock merged commit 86f46b1 into ossf:main Dec 3, 2024
36 checks passed
@JamieMagee JamieMagee deleted the azure-devops-search branch December 3, 2024 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spencerschrock spencerschrock spencerschrock approved these changes

@raghavkaul raghavkaul Awaiting requested review from raghavkaul raghavkaul is a code owner automatically assigned from ossf/scorecard-maintainers

Assignees
No one assigned
Labels
None yet
Projects
Scorecard - NEW
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JamieMagee @spencerschrock